symbolizer: catch errors when closing pipes for crashed symbolizers#5356
Merged
Conversation
If llvm-symbolizer crashes, trying to close its existing pipes throws an error. This currently causes the whole task to crash. This PR fixes this by catching those errors. Also adds logging to see what the symbolizer error was and tests for those logs and for symbolizer crashes.
dylanjew
approved these changes
Jul 9, 2026
Collaborator
Author
|
This has been running on dev all day. There hasn't been any issues and there've been multiple successful symbolizations: http://shortn/_pun7PZwY96 |
Collaborator
Author
|
@javanlacerda PTAL! This is to fix the outage in https://crbug.com/532093354 |
PauloVLB
approved these changes
Jul 10, 2026
javanlacerda
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If llvm-symbolizer crashes, trying to close its existing pipes throws
an error. This currently causes the whole task to crash. This PR fixes
this by catching those errors.
Also adds logging to see what the symbolizer error was and tests for
those logs and for symbolizer crashes.