Skip to content

symbolizer: add logging for symbolizer errors #5354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
g-ortuno wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −4
Open

symbolizer: add logging for symbolizer errors #5354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions src/clusterfuzz/_internal/crash_analysis/stack_parsing/stack_symbolizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@
# Disable all pylint warnings/errors as this is based on external code.
# pylint: disable-all

import collections
import os
import re
import subprocess
import sys
import threading

from clusterfuzz._internal.base import utils
from clusterfuzz._internal.google_cloud_utils import storage
Expand Down Expand Up @@ -240,6 +242,7 @@ def __init__(self, symbolizer_path, default_arch, system, dsym_hints=[]):
self.default_arch = default_arch
self.system = system
self.dsym_hints = dsym_hints
self.stderr_buffer = collections.deque(maxlen=100)
self.pipe = self.open_llvm_symbolizer()

def open_llvm_symbolizer(self):
Expand Down Expand Up @@ -270,7 +273,19 @@ def open_llvm_symbolizer(self):

# Run the symbolizer.
pipe = subprocess.Popen(
cmd, env=env_copy, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
cmd,
env=env_copy,
stdin=subprocess.PIPE,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE)

def read_stderr(p, buffer):
for line in iter(p.stderr.readline, b''):
buffer.append(line.decode('utf-8', errors='replace'))

threading.Thread(
target=read_stderr, args=(pipe, self.stderr_buffer),
daemon=True).start()

global pipes
pipes.append(pipe)
Expand All @@ -296,9 +311,14 @@ def symbolize(self, addr, binary, offset):
file_name = self.pipe.stdout.readline().rstrip().decode('utf-8')
result.append(get_stack_frame(binary, addr, function_name, file_name))

except Exception:
logs.error('Symbolization using llvm-symbolizer failed for: "%s".' %
symbolizer_input)
except Exception as e:
return_code = self.pipe.poll()
stderr_content = ''.join(self.stderr_buffer).strip()
stderr_msg = f' Stderr: {stderr_content}' if stderr_content else ''
exit_msg = f' (exit code {return_code})' if return_code is not None else ''
logs.error(
f'Symbolization using llvm-symbolizer failed{exit_msg} for: "{symbolizer_input}".{stderr_msg}'
)
result = []
if not result:
result = None
Expand Down
Loading