Fix checkpoint saving using wrong interval config - #320
Open
Mr-Neutr0n wants to merge 2 commits into
Open
Conversation
The checkpoint saving condition checked `config.checkpoint_every` to determine whether checkpointing is enabled, but then incorrectly used `config.eval_every` for the modulo operation. This caused checkpoints to be saved at evaluation intervals instead of the configured checkpoint intervals, making the `checkpoint_every` config value effectively ignored. Replace `step % config.eval_every` with `step % config.checkpoint_every` so checkpoints are saved at the intended frequency.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Hi! Quick status: this still applies cleanly to the latest main as of today, and the CI/mergeable state is mergeable with all current checks passing. Re-requesting a review — happy to update for any feedback, and just as happy to close if the repo has moved on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The checkpoint saving condition checked config.checkpoint_every to determine whether checkpointing was enabled, but used config.eval_every for the modulo operation. That caused checkpoints to follow evaluation intervals instead of the configured checkpoint interval.
The fix now routes the decision through a small _should_checkpoint helper that consistently uses config.checkpoint_every. The final training step is still always checkpointed, including when periodic checkpointing is disabled.
Regression coverage
The previous integration test used total_steps = 1, so it always exercised the final-step fallback and could not catch the interval mix-up. The new parameterized cases cover:
Verification
This change was prepared with AI assistance under human direction and review.