Use the MediaError message attribute if available#1727
Open
bausmeier wants to merge 1 commit into
Open
Conversation
The `message` attribute on the `MediaError` object returned by `HTMLMediaElement.error` contains specific diagnostic details about the error if available, or an empty string otherwise. If this message is available then it will be passed with the `loaderror`, otherwise the code will be passed as before. See https://html.spec.whatwg.org/multipage/media.html#error-codes.
Author
|
Context for this is that we're receiving error reports that just say |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue/Feature
Prefer the
messageattribute on the error over thecodeattribute because it contains more specific diagnostic information.Related Issues
I couldn't find any.
Solution
The
messageattribute on theMediaErrorobject returned byHTMLMediaElement.errorcontains specific diagnostic details about the error if available, or an empty string otherwise.If this message is available then it will be passed with the
loaderror, otherwise the code will be passed as before.See https://html.spec.whatwg.org/multipage/media.html#error-codes.
Reproduction/Testing
Trigger a media error, and observe that a string message is provided to
onloaderrorinstead of a code.The easiest option is to use a non-existent source:
Which will print something like
Failed to init decoderinstead of4.Breaking Changes
The
onloaderrorwas already being called with a message in most cases, so I wouldn't consider this a breaking change.