internal/analysis/driverutil: report partial success in ApplyFixes#79843
Open
AshvinBambhaniya wants to merge 1 commit into
Open
internal/analysis/driverutil: report partial success in ApplyFixes#79843AshvinBambhaniya wants to merge 1 commit into
AshvinBambhaniya wants to merge 1 commit into
Conversation
When the fix tool applies some suggested fixes but skips others due to conflicts, it previously returned a non-zero exit code. This caused the 'go fix' command to assume the tool failed, leading it to discard the partial progress (the FixArchive) and not update the source files. On subsequent runs, the tool would see the original code again and repeat the same partial fixes, creating an infinite loop. This change modifies ApplyFixes to return nil (success) if at least one fix was applied and no I/O errors occurred. This ensures that partial progress is saved to disk, breaking the non-convergence loop. Fixes golang#78493
Contributor
|
This PR (HEAD: 470d26a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/787260. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the fix tool applies some suggested fixes but skips others due to
conflicts, it previously returned a non-zero exit code.
This caused the 'go fix' command to assume the tool failed, leading it
to discard the partial progress (the FixArchive) and not update the
source files. On subsequent runs, the tool would see the original code
again and repeat the same partial fixes, creating an infinite loop.
This change modifies ApplyFixes to return nil (success) if at least
one fix was applied and no I/O errors occurred. This ensures that
partial progress is saved to disk, breaking the non-convergence loop.
Fixes #78493