syscall: add //go:norace to rawSyscall on darwin by SebTardif · Pull Request #79805 · golang/go

SebTardif · 2026-06-03T13:47:01Z

On darwin, rawSyscall, rawSyscall6, and rawSyscall9 are Go
functions (not assembly as on Linux) that get race-detector
instrumentation. When forkAndExecInChild calls rawSyscall in
the forked child process, the TSan ThreadState pointer is
invalid, causing SIGSEGV in TraceSwitchPartImpl.

Add //go:norace to these functions so the race detector does
not instrument them. Also update the stale comment in
exec_libc2.go that referred to rawSyscall as assembly.

Fixes #79804

On darwin, rawSyscall, rawSyscall6, and rawSyscall9 are Go functions (not assembly as on Linux) that get race-detector instrumentation. When forkAndExecInChild calls rawSyscall in the forked child process, the TSan ThreadState pointer is invalid, causing SIGSEGV in TraceSwitchPartImpl. Add //go:norace to these functions so the race detector does not instrument them. Also update the stale comment in exec_libc2.go that referred to rawSyscall as assembly. Fixes golang#79804

gopherbot · 2026-06-03T14:13:43Z

This PR (HEAD: 351555f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/786620.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-06-03T14:50:59Z

Message from t hepudds:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-03T14:51:00Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-06-03T14:24:34Z","revision":"bac5dc29d1cbca9323a0500e219fe3c6127d4132"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-03T15:09:34Z

Message from t hepudds:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_28792>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-03T15:09:36Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-03T15:09:37Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-03T17:53:28Z

Message from Michael Pratt:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-03T21:13:59Z

Message from Quim Muntal:

Patch Set 1: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

…rom linux

gopherbot · 2026-06-03T22:25:30Z

This PR (HEAD: 21d5744) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/786620.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-06-03T23:31:14Z

Message from Sébastien Tardif:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-03T23:44:24Z

Message from t hepudds:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-03T23:44:25Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-06-03T23:26:50Z","revision":"cac733bc14569e51d27701420a8379cee2bfd721"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-03T23:57:26Z

Message from t hepudds:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_28792>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-03T23:57:27Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-03T23:57:28Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/786620.
After addressing review feedback, remember to publish your drafts!

SebTardif mentioned this pull request Jun 3, 2026

Intermittent segmentation fault in terraform binary when running many UnitTest instances in parallel hashicorp/terraform-plugin-testing#659

Open

address review: add norace to errno helpers, copy directive comment f…

21d5744

…rom linux

Conversation

SebTardif commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

gopherbot commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants