regexp: re-order short input fast path#79645
Conversation
|
This PR (HEAD: 94446e1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/782600. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/782600. |
|
Message from Ian Lance Taylor: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/782600. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-05-25T03:10:43Z","revision":"ef2539006ec2d687ef1d3e100520ae02a222c739"} Please don’t reply on this GitHub thread. Visit golang.org/cl/782600. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/782600. |
|
Message from Ian Lance Taylor: Patch Set 1: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5206>) Please don’t reply on this GitHub thread. Visit golang.org/cl/782600. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/782600. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/782600. |
|
Message from Olivier Mengué: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/782600. |
|
Message from Keith Randall: Patch Set 1: Auto-Submit+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/782600. |
|
Message from Keith Randall: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/782600. |
|
LGTM from a correctness perspective. It would be helpful to include a benchstat for the short-input case, since the change is specifically optimizing that fast path. |
Input len is less than regexp min len will not rely on dstCap not nil.