fix(context): Copy() copies Errors and Accepted fields#4695
Open
Amirhf1 wants to merge 2 commits into
Open
Conversation
Accepted as nil even when set on the original context. Goroutines receiving a copied context could not observe errors attached before the copy, and content-negotiation state set by middleware was silently lost.
…n(t, cp.Errors, 2) to satisfy the testifylint linter rule
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4695 +/- ##
==========================================
- Coverage 99.21% 98.38% -0.83%
==========================================
Files 42 48 +6
Lines 3182 3166 -16
==========================================
- Hits 3157 3115 -42
- Misses 17 42 +25
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy()now copies theErrorsslice so goroutines receiving a copy can observe errors attached before the copy was made.Copy()now copies theAcceptedslice so content-negotiation state set by middleware (viaSetAccepted) is preserved in the copy.Both fields use independent slices — mutations on the copy do not affect the original context.
Context.Copy()was explicitly copyingKeysandParamsbutomitted
ErrorsandAccepted, leaving them asnilin the copiedcontext regardless of the original's state.