Skip to content

Removed some redundant content and modified some of the execution logic (may be of limited use). #4689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
REDDDG wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −8
Open

Removed some redundant content and modified some of the execution logic (may be of limited use). #4689

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78d2282
1：tagValue only needs to be assigned once, which removes an unnecessa…
REDDDG Jun 3, 2026
ffc6082
Refactor option handling with switch statement
REDDDG Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions binding/form_mapping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,24 +143,24 @@ type setOptions struct {
}

func tryToSetValue(value reflect.Value, field reflect.StructField, setter setter, tag string) (bool, error) {
var tagValue string
var setOpt setOptions

tagValue = field.Tag.Get(tag)
tagValue, opts := head(tagValue, ",")
tagValue, opts := head(field.Tag.Get(tag), ",")

if tagValue == "" { // default value is FieldName
if field.Name == "" {
return false, nil
}
tagValue = field.Name
}
if tagValue == "" { // when field is "emptyField" variable
return false, nil
}

var opt string
for len(opts) > 0 {
opt, opts = head(opts, ",")

if k, v := head(opt, "="); k == "default" {
k, v := head(opt, "=")
switch k {
case "default":
setOpt.isDefaultExists = true
setOpt.defaultValue = v

Expand All @@ -171,7 +171,7 @@ func tryToSetValue(value reflect.Value, field reflect.StructField, setter setter
setOpt.defaultValue = strings.ReplaceAll(v, ";", ",")
}
}
} else if k, v = head(opt, "="); k == "parser" {
case "parser":
setOpt.parser = v
}
}
Expand Down