feat: add SkipMethodNotAllowedMiddleware option#4687
Open
goingforstudying-ctrl wants to merge 2 commits into
Open
feat: add SkipMethodNotAllowedMiddleware option#4687goingforstudying-ctrl wants to merge 2 commits into
goingforstudying-ctrl wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4687 +/- ##
==========================================
- Coverage 99.21% 98.38% -0.83%
==========================================
Files 42 48 +6
Lines 3182 3163 -19
==========================================
- Hits 3157 3112 -45
- Misses 17 42 +25
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Adds a new Engine option that, when enabled, prevents global middleware registered via Use() from being executed for 405 Method Not Allowed responses. This allows NoMethod handlers to run without triggering middleware that may reject the request (e.g., authentication, checksum validation) before the 405 response can be sent. Fixes gin-gonic#4189
goingforstudying-ctrl
force-pushed
the
fix/nomethod-middleware-bypass
branch
from
d6377df to
e3d8bf2
Compare
goingforstudying-ctrl
force-pushed
the
fix/nomethod-middleware-bypass
branch
2 times, most recently
from
cd916b6 to
e3d8bf2
Compare
Author
|
Pushed fix: bumped quic-go to v0.59.1 to resolve CVE-2026-40898 (MEDIUM). Trivy scan should now pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Engine.SkipMethodNotAllowedMiddlewareflag that, when enabled, prevents global middleware from running on 405 Method Not Allowed responses. This allows NoMethod handlers to respond correctly without being intercepted by middleware such as authentication or checksum validation that would otherwise reject the request first.Fixes #4189