fix: skip chmod for existing SaveUploadedFile destination directories#4647
Open
mike-lmctl wants to merge 1 commit into
Open
fix: skip chmod for existing SaveUploadedFile destination directories#4647mike-lmctl wants to merge 1 commit into
mike-lmctl wants to merge 1 commit into
Conversation
When SaveUploadedFile targets a path under an existing directory, applying the optional permission mode to that existing directory can fail despite the file creation itself being allowed. This change only creates and chmods the destination directory when it does not already exist. The permission tests now cover both newly created upload directories and existing destination directories whose mode should be preserved. Tested: docker run --rm --user "$(id -u):$(id -g)" -e GOMODCACHE=/tmp/gomodcache -e GOCACHE=/tmp/gocache -v "$PWD":/src -w /src golang:1.25.0 go test . -count=1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
SaveUploadedFileso it no longer changes permissions on destinationdirectories that already exist. It still creates and applies the requested mode
to directories that Gin creates for the upload path.
The package tests pass in a Go 1.25 Docker container.