Skip to content

fix(files): prune dependency dirs in expandFileGlobs before fast-glob traversal#410

Draft
dcramer wants to merge 4 commits into
mainfrom
fix/prune-vendor-dirs-in-glob-expansion
Draft

fix(files): prune dependency dirs in expandFileGlobs before fast-glob traversal#410
dcramer wants to merge 4 commits into
mainfrom
fix/prune-vendor-dirs-in-glob-expansion

fix(files): prune dependency dirs in expandFileGlobs before fast-glob…

bddfaed
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: code-review completed Jun 16, 2026 in 0s

1 issue

code-review: Found 1 issue (1 low)

Low

User negation overrides for dot directories (`.next`, `.nuxt`, `.cache`) are silently ineffective - `packages/warden/src/cli/files.ts:27-31`

The three dot-prefixed entries in BUILTIN_PRUNE_DIRECTORY_PATTERNS (**/.next/**, **/.nuxt/**, **/.cache/**) are redundant with dot: false in the fast-glob call, so removing them from the ignore list via a user negation (e.g. !.next/**) has no effect — fast-glob still skips dot directories entirely, silently defeating the documented override.


⏱ 9m 50s · 848.2k in / 58.5k out · $1.71