security: upgrade urllib3 to 2.7.0 and AWS SDK for compatibility#7745
Draft
wtfiwtz wants to merge 1 commit into
Draft
security: upgrade urllib3 to 2.7.0 and AWS SDK for compatibility#7745wtfiwtz wants to merge 1 commit into
wtfiwtz wants to merge 1 commit into
Conversation
Upgrade urllib3 from 1.26.19 to 2.7.0 (major version) to address multiple security vulnerabilities. This requires upgrading boto3/botocore and temporarily removing advocate (blocks urllib3 2.x). SSRF protection will be restored via champion in a follow-up PR. Changes: - urllib3: 1.26.19 → 2.7.0 - boto3: 1.28.8 → 1.43.7 - botocore: 1.31.8 → 1.43.7 - Add transitive dependencies: azure-core >=1.38.0, grpcio >=1.80.0, h11 >=0.16.0, httpcore >=1.0.9, marshmallow >=3.26.2 - Remove advocate (temporarily) - blocks urllib3 2.x upgrade - Update redash/utils/requests_session.py to use requests directly CVEs Addressed: - CVE-2023-43804 (urllib3): Cookie header injection - CVE-2024-37891 (urllib3): Proxy-authorization header leak on redirect - Multiple urllib3 1.26.x → 2.x security fixes Breaking Changes: - ENFORCE_PRIVATE_ADDRESS_BLOCK setting is temporarily non-functional - SSRF protection will be restored via champion package in PR getredash#7746 Testing: - ✅ Python tests pass - ✅ Frontend tests pass - ✅ poetry lock regenerates successfully Release Notes: - urllib3: https://github.com/urllib3/urllib3/releases/tag/2.7.0 - boto3: https://github.com/boto/boto3/releases/tag/1.43.7 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade urllib3 from 1.26.19 to 2.7.0 (major version) to address multiple security vulnerabilities. This requires upgrading boto3/botocore and temporarily removing advocate (which blocks urllib3 2.x). SSRF protection will be restored via champion in PR #7746.
Changes
urllib3: 1.26.19 → 2.7.0boto3: 1.28.8 → 1.43.7 (botocore 1.31.x pinned urllib3 <1.27, blocking the upgrade)botocore: 1.31.8 → 1.43.7azure-core>=1.38.0grpcio>=1.80.0,<2h11>=0.16.0httpcore>=1.0.9marshmallow>=3.26.2advocate(temporarily) - blocks urllib3 2.x due tourllib3 <2.0pinredash/utils/requests_session.pyto userequestsdirectlyCVEs Addressed
Breaking Changes
advocatelibrary was removed because it requiresurllib3 <2.0championpackage in PR security: replace advocate with champion and upgrade urllib3 to 2.x #7746Testing
poetry lockregenerates successfullyDependencies
Release Notes
Made with Cursor