Honor clickable for Markers in Google Maps#7318
Open
seadowg wants to merge 4 commits into
Open
Conversation
grzesiek2010
requested changes
Jul 21, 2026
| marker.setIcon(getBitmapDescriptor(context, markerIconDescription)); | ||
| } | ||
|
|
||
| public boolean isClickable() { |
Member
Author
There was a problem hiding this comment.
I think I'd prefer to leave it private like the other methods on this class. The outer class can access it because Java (if it was Kotlin we'd have a file private class instead), but it makes more sense to have the inner class be private to the outer class and then have the methods used by things outside the inner class be public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7313
Why is this the best possible solution? Were any other approaches considered?
Google Maps doesn't offer a way to make markers non-clickable so we need to determine whether we should call the feature listener or the map click listener when a marker click occurs here. That does mean that trying to add a point or a line/shape vertex by clicking on a marker will always add the new feature at exactly the same location: that could be considered feature.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should just fix the issue! As mentioned above, clicking on a marker will always count as a click on the exact point of the marker which means that new features being added via clicks will snap to it.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest