Ensure 'envs' key exists in config before updating - #107
Open
mkardach wants to merge 1 commit into
Open
Conversation
Piotr Pękala (p-pekala)
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
k8s_parameters_loader.pyscript to ensure that theenvskey is present in the configuration dictionary before attempting to update it. Previously, the absence of theenvskey would lead to a KeyError, disrupting the configuration process. The modification includes a conditional check that initializesenvsas an empty dictionary if it is not already present, thus preventing any errors when updating the configuration with the DATAHUB_GMS_URL.