Skip to content

Added shorthash to git functions#2752

Closed
voronoipotato wants to merge 3 commits into
fsprojects:masterfrom
voronoipotato:patch-1
Closed

Added shorthash to git functions#2752
voronoipotato wants to merge 3 commits into
fsprojects:masterfrom
voronoipotato:patch-1

Conversation

@voronoipotato

Copy link
Copy Markdown
Contributor

Description

Grabs the shorthash

Comment thread src/app/Fake.Tools.Git/Information.fs Outdated
@voronoipotato

Copy link
Copy Markdown
Contributor Author

@xperiandri what do you think :) ?

@voronoipotato

Copy link
Copy Markdown
Contributor Author

@xperiandri Ah I see, I need to run fantomas on it to merge. I'll handle that after work today.

@xperiandri

Copy link
Copy Markdown
Collaborator

@voronoipotato could you format your changes? Build fails

@xperiandri

Copy link
Copy Markdown
Collaborator

@DanielRowe1 let's merge this and I will release

@voronoipotato

Copy link
Copy Markdown
Contributor Author

Thanks! We use the shorthash at my work sometimes so this is pretty nice.

@voronoipotato

Copy link
Copy Markdown
Contributor Author

I'll format it after work today. Thanks!

@Numpsy

Numpsy commented Jan 9, 2024

Copy link
Copy Markdown
Contributor

fwiw I think Fantomas might just want empty lines adding before and after the new function

@xperiandri

Copy link
Copy Markdown
Collaborator

@voronoipotato

@Numpsy

Numpsy commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

I tried tweaking the formatting in a separate branch over at Numpsy@ad0da7c and the formatting step of the CI build worked - https://github.com/Numpsy/FAKE/actions/runs/7504044055 - though that intermitent macOS build failure happened in the integration tests.

Not sure if I'd be able to update this PR though, or if it'd need a new one off my fork.

@Numpsy

Numpsy commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

@voronoipotato This addition has hopefully been merged in #2770 now

@xperiandri

Copy link
Copy Markdown
Collaborator

@voronoipotato you can delete the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants