Update STACKIT SDK#882
Draft
robinschneider wants to merge 9 commits into
Draft
Conversation
Signed-off-by: Robin Schneider <mail@robinschneider.dev>
robinschneider
force-pushed
the
stackit-improvements
branch
from
63774c4 to
e621608
Compare
tormath1
reviewed
Jul 10, 2026
Comment on lines
+479
to
+483
| ip.Labels = labels | ||
| break | ||
| } | ||
| verifiedIpAddress = ip | ||
| return nil |
Contributor
There was a problem hiding this comment.
Suggested change
| ip.Labels = labels | |
| break | |
| } | |
| verifiedIpAddress = ip | |
| return nil | |
| ipAddress.Labels = labels | |
| return nil | |
| } | |
| return nil |
Member
Author
There was a problem hiding this comment.
It is now outdated, not sure if it is resolved as requested
Comment on lines
+465
to
+468
| ip, err := a.client.GetPublicIP(ctx, a.projectID, a.region, ipAddress.GetId()).Execute() | ||
| if err != nil { | ||
| return fmt.Errorf("getting public IP: %w", err) | ||
| } |
Contributor
There was a problem hiding this comment.
Instead of "getting" the IP, can't we just update it directly? If the labels are already here, it's a no-op otherwise it sets them?
Member
Author
There was a problem hiding this comment.
Good point, but now I am thinking about if we should keep it and log it to find out if the issue get fixed in the future?
Signed-off-by: Robin Schneider <mail@robinschneider.dev>
Signed-off-by: Robin Schneider <mail@robinschneider.dev>
Signed-off-by: Robin Schneider <mail@robinschneider.dev>
Signed-off-by: Robin Schneider <mail@robinschneider.dev>
Signed-off-by: Robin Schneider <mail@robinschneider.dev>
Signed-off-by: Robin Schneider <mail@robinschneider.dev>
Signed-off-by: Robin Schneider <mail@robinschneider.dev>
robinschneider
force-pushed
the
stackit-improvements
branch
from
65d9f75 to
ea08892
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update STACKIT SDK & improve garbage collection and deletion
STACKIT resource deletion fails regularly and the garbage collection fails to clean up these resources.
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.