Add review-publisher skill#941
Open
MaxDall wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
review-publisheragent skill: it reviews a Fundus publisher PR (a new publisher, or an added/changed parser version) by crawling live articles and verifying the extractedArticleBodymirrors the real article — no dropped paragraphs, no leaked boilerplate — then drafts a single GitHub review.Built on the skills framework from its companion PR #940, but independent of it: the scripts run standalone (
python skills/review-publisher/scripts/review.py …) and don't import the installer.How it works
A crawl-once-then-sweep flow is a hard gate on every publisher under review:
scripts/review.py— the driver (crawl/sweep/show/adjudicate/status/payload). Every candidate the sweep surfaces must be explicitly adjudicated, andstatusmust reportREADYbefore any verdict.scripts/_sweep.py— diffs the extracted body against the live document to catch missing/leaked content.scripts/_store.py— persists crawl/adjudication state across invocations.scripts/sampler/— layout sampling, so the crawl picks structurally diverse articles instead of near-duplicates.SKILL.md/PLAYBOOK.md— the agent-facing entry point and step-by-step procedure.Library change
Adds
BaseParser.body_selectors()(src/fundus/parser/base_parser.py) — a public accessor returning a version'ssummary/subheadline/paragraphselectors. This gives external tooling (the skill) a supported way to read them instead of reaching into the private_*_selectorattributes.Testing
tests/test_review_skill.pypins the sweep gate's failure modes — above all, the ways it could report a silent false "clean".