fix(lora): resume from checkpoint fails due to strict state_dict loading#1296
Open
duchengyao wants to merge 1 commit into
Open
fix(lora): resume from checkpoint fails due to strict state_dict loading#1296duchengyao wants to merge 1 commit into
duchengyao wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this PR adding new feature or fix a BUG?
Fix BUG.
Is this pull request related to any issue? If yes, please link the issue.
#1295
Problem
TextToSemantic.on_save_checkpointintentionally saves only LoRA parameters to reduce checkpoint size (~100MB vs ~9GB). However, this causes Lightning'srestore_model()to fail during resume becauseload_state_dictis called withstrict=True, and the frozen base model weights are missing from the saved state_dict.Fix
Override
load_state_dictinTextToSemanticto always usestrict=False.from_pretrained)Before
After
LoRA training resumes from checkpoint with no errors.
Files changed
fish_speech/models/text2semantic/lit_module.py— addload_state_dictoverrideTesting
Tested on a single RTX 4090 (48GB) with LoRA r=8 on s2-pro: