Add support for convertDate and convertVarchar on duckDB#4813
Open
mahekk-gs wants to merge 22 commits into
Open
Add support for convertDate and convertVarchar on duckDB#4813mahekk-gs wants to merge 22 commits into
mahekk-gs wants to merge 22 commits into
Conversation
* initial implementation for union * minor error fixes * reverted union changes * minor fix * minor fix * changed pk inference * minor fix * minor fix * minor fix * minor fix * minor fix * minor fix * code changes for: moving pk inference to core pure module, other minor fixes and #SQL instance pk resolution * tests added * minor fix * minor fix * minor fix * minor fix * minor fix * minor fix * minor fix * minor fix * impl compiler extension * minor fix * minor fix * minor fix * moved pk resolution to 3rd pass * used pure extension * minor fix * minor fix * minor fix * minor fix * minor fix * used pure extensions instead of compiler extension * moved pk resolution to runtime * minor test fix * minor fix * added extension for SQL Expression * minor sql test change * minor sql test change * minor sql test change * minor sql test change * minor sql test change * minor sql test change * moved builder pass logic to validator, modified relationfuncmapping.pure with suggested changes to handle views as well. * used prerequisite elements to validate pk in thirdpassbuilder. reverted relationalvalidator change. Removed sug agg changes. * modified single pk syntax * minor fix * cleaned comments * cleaned comments * minor fix in builderpass * minor fixes * minor fixes
* Add EMIT test authoring guide * Rename RelationalEMITTestSuite to RelationalEMITTests * Add cross-feature EMIT test * Update action versions in build.yml
* Update RelationFunctionClassMapping.java * Update RelationFunctionMappingParseTreeWalker.java * Update TestMappingGrammarParser.java
…mpilerHelper (finos#4797) * Fix PackageableElement resolution in EmbeddedDataCompilerHelper * Clean-up implementations of EmbeddedDataCompilerHelper
* Add support for array_to_string for variant and semistructured * Update skipped tests for H2 * Refine changes to only support joinStrings * add PCT test for variant joinStrings * Fix test and update expected failures
* Fix hardcoded integer column type in plan generation * add safety checks to type inference method * add safety checks to type inference method
…#4769) The Pure-native tests under platform_store_relational/tests/ (added by legend-pure PR finos/legend-pure#1268) call executeInDb and need H2/DuckDB JDBC drivers at runtime. They're declared in package meta::relational::tests, so Test_Pure_Relational's recursive collection from meta::relational picks them up. This engine module doesn't ship those JDBC drivers (it's not a DB-execution test harness), so the tests error with "No suitable driver" on every collection. Filter them out via getSourceInformation().getSourceId().startsWith( "/platform_store_relational/tests/") in the predicate, matching the existing pattern in TestCollection.buildPCTTestCollection. The tests remain exercised by legend-pure's own TestPureDBFunction runner, which ships H2 + duckdb_jdbc. The companion legend-pure PR 1268 also moves the AfterPackage hooks (afterLoad_duckdb/afterLoad_h2) into meta::relational::tests::loadValues, which addresses the parallel fan-out failures in Test_Pure_Relational_ConnectionEquality and Test_Relational_UsingPureClientTestSuite — those don't need an engine-side change because they only inherit the AfterPackage hooks through ancestor walking.
* Add ModelJoin Parser and Compiler * builder.pure refactor * temp commit * union support * more tests * move tests to Pure Compiler * move tests to Pure Compiler * move tests to Pure Compiler * move tests to Pure Compiler * add docs * update legend-pure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why is it needed ?
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?