Fix Group A headers and Group B memory bugs#2
Merged
Conversation
…#84) - Fix delete→free in Morlet::getWavelet() for malloc-allocated memory - Fix memory leak: free lastscalemem with _aligned_free/_aligned_malloc on Windows, free/aligned_alloc on POSIX - Add missing <cassert> include (issue #84) - Also fix indentation in convolve() else branch Co-Authored-By: Oz <oz-agent@warp.dev>
The create_FFT_optimization_plan method expects a string flag (e.g., "FFTW_ESTIMATE") not an integer. This fixes the TypeError. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes for Group A (missing headers) and Group B (memory bugs) from ISSUES_PLAN.md.
Group A - Missing C++ Headers (Issue #84)
#include <cassert>to fix compile failures on MSVC/MinGWGroup B - Memory Bugs (Issues #74, #55)
delete→free()inMorlet::getWavelet()for malloc-allocated memory (undefined behavior)lastscalememwith_aligned_free()(Windows) /free()(POSIX) inconvolve()convolve()else branchFiles Changed
src/fcwt/fcwt.cpp- header fix and memory leak fixesCo-Authored-By: Oz oz-agent@warp.dev