Improve: fix nested code block and expand Common Suggestions in Rust bob mentoring#2405
Open
PaezCande wants to merge 1 commit into
Open
Improve: fix nested code block and expand Common Suggestions in Rust bob mentoring#2405PaezCande wants to merge 1 commit into
PaezCande wants to merge 1 commit into
Conversation
PaezCande
commented
Jun 14, 2026
PaezCande
commented
Contributor
- Fixed malformed nested code block in the match suggestion
- Expanded Common Suggestions with three new idiomatic Rust tips:
- Prefer zero-allocation char checks over .to_uppercase()
- Prefer .chars().any() over .contains() for character property checks
- Prefer match on tuple over nested if/else
…bob mentoring - Fixed malformed nested code block in the match suggestion - Expanded Common Suggestions with three new idiomatic Rust tips: - Prefer zero-allocation char checks over .to_uppercase() - Prefer .chars().any() over .contains() for character property checks - Prefer match on tuple over nested if/else
IsaacG
reviewed
Jun 14, 2026
| ``` | ||
|
|
||
| If they don't use a `match` to compare the conditions: | ||
| ````md |
Member
There was a problem hiding this comment.
This is intentional and formats correctly. This is not malformed.
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback and for fixing the code block! The three new Common Suggestions are still included. Let me know if there's anything else to adjust.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.