Prefer reporting an error instead of triggering an assert#5865
Open
bjoernQ wants to merge 6 commits into
Open
Conversation
MabezDev
reviewed
Jul 10, 2026
MabezDev
left a comment
MabezDev
left a comment
Member
There was a problem hiding this comment.
I'd like a HIL test if we can make one 🥺
| raw: DynChannelAccess<Rx>, | ||
| final_: bool, | ||
| ) { | ||
| ) -> bool { |
Member
There was a problem hiding this comment.
Needs some docs explaining what the return value means imo
Contributor
Author
Will try as soon as I get probe-rs to talk to EspProg again (on my machine) |
bjoernQ
force-pushed
the
esp32-fix-rmt-rx
branch
from
ceb5a0b to
3548e67
Compare
bugadani
reviewed
Jul 10, 2026
Comment on lines
+1263
to
+1265
| for _ in 0..1000 { | ||
| tx.toggle(); | ||
| } |
Contributor
There was a problem hiding this comment.
I think this test could use a bit of explanation - why do we toggle a GPIO at full speed in an async block?
Contributor
Author
There was a problem hiding this comment.
ok - that looks definitely sus - hope the added comments help a little bit. it's generally an odd issue
Contributor
There was a problem hiding this comment.
Should we try and blast a stable-ish SPI clock into the RMT input instead of a GPIO signal of undeterminate frequency?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4697
On ESP32 (and most probably ESP32-S2) there are situations when the end-interrupt got triggered with an prematurely (while it should be an error)
Reproducing with the (modified) embassy_rmt_rx example:
Don't connect GPIO4 -> GPIO5, run the example, wait a bit, connect GPIO4+GPIO5 (or even just touch the pins) .... the assert triggered.
Now this condition is reported as an error.
I was considering adding an HIL test without success - I can put more effort into that if we think it's really needed