fix: Missing import when building with SPI driver in RAM#5585
Merged
Conversation
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5585-to-esp-hal-1.1.x
git worktree add --checkout .worktree/backport-5585-to-esp-hal-1.1.x backport-5585-to-esp-hal-1.1.x
cd .worktree/backport-5585-to-esp-hal-1.1.x
git reset --hard HEAD^
git cherry-pick -x 2c57b119445dcca2fe81523ec5616f61cd838b10
git push --force-with-lease |
MabezDev
pushed a commit
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.skip-changelogormanual-changeloglabel as appropriate.Extra:
Pull Request Details 📖
Description
Somewhere between the last release (1.1.0) and the current main (50f4e58) an issue was introduced to the SPI DMA implementation. The sram attribute wasn't being imported when ESP_HAL_CONFIG_PLACE_SPI_MASTER_DRIVER_IN_RAM is enabled. As such, esp-hal would fail to compile.
Testing
Tested by building the SPI example with
ESP_HAL_CONFIG_PLACE_SPI_MASTER_DRIVER_IN_RAM = "true", as well as running the ESP32-S3 hil tests.Changelog
esp-hal
ESP_HAL_CONFIG_PLACE_SPI_MASTER_DRIVER_IN_RAM = "true"