Skip to content

fix: Missing import when building with SPI driver in RAM#5585

Merged
MabezDev merged 1 commit into
esp-rs:mainfrom
danielstuart14:fix_spi_sram
May 20, 2026
Merged

fix: Missing import when building with SPI driver in RAM#5585
MabezDev merged 1 commit into
esp-rs:mainfrom
danielstuart14:fix_spi_sram

Conversation

@danielstuart14

Copy link
Copy Markdown
Contributor

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • I have added changelog entries and/or migration guide notes in the sections below, or I will ask a maintainer to add the skip-changelog or manual-changelog label as appropriate.
  • My changes are in accordance to the esp-rs developer guidelines

Extra:

Pull Request Details 📖

Description

Somewhere between the last release (1.1.0) and the current main (50f4e58) an issue was introduced to the SPI DMA implementation. The sram attribute wasn't being imported when ESP_HAL_CONFIG_PLACE_SPI_MASTER_DRIVER_IN_RAM is enabled. As such, esp-hal would fail to compile.

Testing

Tested by building the SPI example with ESP_HAL_CONFIG_PLACE_SPI_MASTER_DRIVER_IN_RAM = "true", as well as running the ESP32-S3 hil tests.


Changelog

esp-hal

  • Fixed: Add missing import when building SPI with ESP_HAL_CONFIG_PLACE_SPI_MASTER_DRIVER_IN_RAM = "true"

@MabezDev MabezDev added the esp-hal-backport Backport this PR to the latest esp-hal-x.y.x branch.” label May 20, 2026

@MabezDev MabezDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue May 20, 2026
Merged via the queue into esp-rs:main with commit 2c57b11 May 20, 2026
45 checks passed
@github-actions

Copy link
Copy Markdown

Created backport PR for esp-hal-1.1.x:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-5585-to-esp-hal-1.1.x
git worktree add --checkout .worktree/backport-5585-to-esp-hal-1.1.x backport-5585-to-esp-hal-1.1.x
cd .worktree/backport-5585-to-esp-hal-1.1.x
git reset --hard HEAD^
git cherry-pick -x 2c57b119445dcca2fe81523ec5616f61cd838b10
git push --force-with-lease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

esp-hal-backport Backport this PR to the latest esp-hal-x.y.x branch.”

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants