ADC: Automatically disable SAR ADC when driver is dropped#5562
Open
JurajSadel wants to merge 4 commits into
Open
ADC: Automatically disable SAR ADC when driver is dropped#5562JurajSadel wants to merge 4 commits into
JurajSadel wants to merge 4 commits into
Conversation
Contributor
|
This should be done when the clock gets released. Right now I can drop the driver and only partially disable it, or I can try and call a fallible destructor that may refuse to work if something else needs the power domain, neither cases are particularly good. |
JurajSadel
force-pushed
the
adc-sleep
branch
2 times, most recently
from
013a041 to
e067390
Compare
Member
|
We need to be a bit careful here too, ADC2 on most chips has a side channel for WiFi entropy, though I can't quite recall where I read that. |
JurajSadel
changed the title
try_disable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2740