fix(xds): preserve path separators in root prefix rewrites#9415
Open
immanuwell wants to merge 1 commit into
Open
fix(xds): preserve path separators in root prefix rewrites#9415immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91403c25f4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9415 +/- ##
==========================================
+ Coverage 75.33% 75.35% +0.02%
==========================================
Files 252 252
Lines 41471 41480 +9
==========================================
+ Hits 31243 31259 +16
+ Misses 8115 8109 -6
+ Partials 2113 2112 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: immanuwell <pchpr.00@list.ru>
immanuwell
force-pushed
the
fix-root-prefix-urlrewrite
branch
from
91403c2 to
f08d6b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Root
PathPrefix "/"rewrites are a bit busted right now. With aURLRewritereplacePrefixMatch: /prefix/,GET /testhits the backend as/prefixtest, not/prefix/test.This switches that one case to regex rewrite. So
/becomes/prefix, and/testbecomes/prefix/test. Non-root prefix rewrites stay the same.Which issue(s) this PR fixes
Fixes #6764
Related #5256
How to reproduce
HTTPRoutewithmatches[].path.value: /andfilters[].urlRewrite.path.replacePrefixMatch: /prefix/.GET /test./prefixtest./prefix/test.Checks
go test ./internal/xds/translator -count=1go test -tags=e2e ./e2e/tests -run TestNonExistent -count=1