-
Notifications
You must be signed in to change notification settings - Fork 843
api: add OOB BackendUtilization #9400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
b0e29a4
5923722
9799120
bbc6f97
6556680
1757841
9e4700c
9f1fa61
7e3446a
aaa35b4
92e6566
34ee3eb
e474be6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -229,6 +229,44 @@ type BackendUtilization struct { | |
| // +optional | ||
| // +kubebuilder:default=false | ||
| KeepResponseHeaders *bool `json:"keepResponseHeaders,omitempty"` | ||
|
|
||
| // OOB enables out-of-band ORCA load reporting. When set, Envoy opens a | ||
| // server-streaming gRPC connection to each endpoint's | ||
| // xds.service.orca.v3.OpenRcaService/StreamCoreMetrics and pulls load | ||
| // reports periodically, instead of relying on in-band ORCA metrics | ||
| // carried in response headers/trailers. | ||
| // | ||
| // The backend must implement OpenRcaService for this to take effect. | ||
| // +optional | ||
| // +notImplementedHide | ||
| OOB *OOBReporting `json:"oob,omitempty"` | ||
|
jukie marked this conversation as resolved.
Outdated
jukie marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| // OOBReporting configures out-of-band ORCA load reporting for the | ||
| // BackendUtilization load balancer. | ||
| // | ||
| // +notImplementedHide | ||
| type OOBReporting struct { | ||
| // ReportingPeriod is how often Envoy requests load reports from the server. | ||
| // If omitted, uses Envoy's default of 10s. | ||
| // +optional | ||
| // +notImplementedHide | ||
| ReportingPeriod *gwapiv1.Duration `json:"reportingPeriod,omitempty"` | ||
|
|
||
| // Port overrides the port used for the OOB reporting connection, e.g. to | ||
| // reach a separate reporting sidecar. Defaults to the endpoint's port. | ||
| // +kubebuilder:validation:Minimum=1 | ||
| // +kubebuilder:validation:Maximum=65535 | ||
|
jukie marked this conversation as resolved.
|
||
| // +optional | ||
| // +notImplementedHide | ||
| Port *uint32 `json:"port,omitempty"` | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should use
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zhaohuabing I ended up reverting this back to
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm going to merge this but will ping you on the implementation PR in case you'd still prefer to use PortNumber |
||
|
|
||
| // Authority overrides the :authority header on the OOB gRPC stream. | ||
| // | ||
| // +kubebuilder:validation:Pattern=`^[^\x00\n\r]*$` | ||
| // +optional | ||
| // +notImplementedHide | ||
| Authority *string `json:"authority,omitempty"` | ||
| } | ||
|
|
||
| // DynamicModuleLBPolicy configures a custom load balancing algorithm | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.