Support off and critical log level#9271
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b11dcbaa44
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - "off" | ||
| - critical |
There was a problem hiding this comment.
When gen-check runs, it invokes helm-template, which rewrites the rendered test/helm/gateway-crds-helm/*.out.yaml files from this template. These new enum entries are now present in the chart template, but a repo search (rg '"off"' test/helm/gateway-crds-helm) shows the gateway-crds-helm goldens were not updated, so CI will leave a dirty tree and fail until the rendered outputs are regenerated.
Useful? React with 👍 / 👎.
| | `off` | LogLevelOff disables logging.<br /> | | ||
| | `critical` | LogLevelCritical defines the "critical" logging level.<br /> | |
There was a problem hiding this comment.
This feature is being added on a tree whose VERSION is v1.8.1, and make docs copies latest into site/content/en/v1.8, not v1.4. Adding these values under site/content/en/v1.4 retroactively documents off/critical for an older release that does not have the API change, while the current site/content/en/v1.8/api/extension_types.md still omits them.
Useful? React with 👍 / 👎.
wweiwei-li
force-pushed
the
logLevel
branch
2 times, most recently
from
6473c80 to
11bec99
Compare
There was a problem hiding this comment.
Hey, Thanks for reviewing it. It was my first contribution, a little confused about what needs to be included and what not.
Just removed it and only depend on run make generate. Now it is only under latest
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9271 +/- ##
==========================================
+ Coverage 75.20% 75.21% +0.01%
==========================================
Files 252 252
Lines 41093 41093
==========================================
+ Hits 30902 30910 +8
+ Misses 8089 8080 -9
- Partials 2102 2103 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Weiwei Li <weiweiww@amazon.com>
|
Rebased. Also updated the release notes to meet new requirements. The previous conformance and E2E tests failed. But it seems not related to my change. I will see how new tests running |
|
tests failed again , but I don't think it is caused by my change |
|
/retest |
|
Hey, @zirain , Can you please let me know if we can merge it or if we need to retest? The failure does not seem related to my changes. Please let me know what I can do next |
|
@wweiwei-li it's a flaky test |
2 participants
What type of PR is this?
This change adds two new log levels
offandcriticalto the LogLevel enum used by EnvoyProxy's logging configuration.What this PR does / why we need it:
Envoy natively supports
offandcriticallog levels, but Envoy Gateway's API previously only exposed trace, debug, info, warn, and error. Users who need to completely silence logging or restrict it to only critical messages had no way to do so through the EnvoyProxy CRD.What
Testing