Skip to content

Remote terms of service and privacy policy - #14894

Open
PabloBuchu wants to merge 6 commits into
developfrom
wip/pb/remote-user-tos
Open

Remote terms of service and privacy policy#14894
PabloBuchu wants to merge 6 commits into
developfrom
wip/pb/remote-user-tos

Conversation

@PabloBuchu

Copy link
Copy Markdown
Contributor

Pull Request Description

Move managing tos and privacy policy acceptance from localStorage to cloud / remote user model.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire vue wrapper is not needed.

You may just move import RegistrationReact... and const Registration = ... directly to router.ts, see other how react pages are loaded there. withDataLoader is no longer needed.

Comment thread app/gui/src/providers/auth.ts Outdated
Comment on lines +139 to +140
tosAccepted: tosHash,
ppAccepted: ppHash,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here we have assumption that user accepted tos and pp during registration? Please add a comment, because it looks little buggy atm.

Also, technically tos and pp could change in a time between registration and first run of the application, but I don't feel we need to cover it right now :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| So here we have assumption that user accepted tos and pp during registration? Please add a comment, because it looks little buggy atm.
yes we do. user can not submit the registration form without checking tos and pp and the hashes are being send within createUser request body

| Also, technically tos and pp could change in a time between registration and first run of the application, but I don't feel we need to cover it right now :)

Backend returns users accepted tos and pp and if they are different than the ones downloaded from pages then users is asked to reconfirm acceptation on applicatio open. Same the new hashes are being send with updateUser request

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see the case you mean.. I will add custom cognito attribues to pass accepted hashes

@PabloBuchu
PabloBuchu requested a review from farmaazon March 31, 2026 10:25
@PabloBuchu PabloBuchu added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 1, 2026
@jdunkerley jdunkerley added this to the 2026.1 Release milestone Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: No changelog needed Do not require a changelog entry for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants