Remote terms of service and privacy policy - #14894
Conversation
There was a problem hiding this comment.
This entire vue wrapper is not needed.
You may just move import RegistrationReact... and const Registration = ... directly to router.ts, see other how react pages are loaded there. withDataLoader is no longer needed.
| tosAccepted: tosHash, | ||
| ppAccepted: ppHash, |
There was a problem hiding this comment.
So here we have assumption that user accepted tos and pp during registration? Please add a comment, because it looks little buggy atm.
Also, technically tos and pp could change in a time between registration and first run of the application, but I don't feel we need to cover it right now :)
There was a problem hiding this comment.
| So here we have assumption that user accepted tos and pp during registration? Please add a comment, because it looks little buggy atm.
yes we do. user can not submit the registration form without checking tos and pp and the hashes are being send within createUser request body
| Also, technically tos and pp could change in a time between registration and first run of the application, but I don't feel we need to cover it right now :)
Backend returns users accepted tos and pp and if they are different than the ones downloaded from pages then users is asked to reconfirm acceptation on applicatio open. Same the new hashes are being send with updateUser request
There was a problem hiding this comment.
oh I see the case you mean.. I will add custom cognito attribues to pass accepted hashes
Pull Request Description
Move managing tos and privacy policy acceptance from localStorage to cloud / remote user model.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.