Skip high-pass filter for stdev and count tiles (#47) - #52
Draft
endolith wants to merge 1 commit into
Draft
Conversation
PDAL writers.gdal count and stdev outputs are point statistics per cell, not elevation surfaces. The Gaussian residual high-pass is only meaningful for min/max/mean/idw elevation rasters. Co-authored-by: endolith <endolith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #47.
The tile pipeline applied the same Gaussian high-pass (elevation minus smoothed elevation) to every
grid_method. For PDALwriters.gdaloutputs count and stdev, that residual is not a meaningful visualization of the statistic and should use the gridded values directly (after NaN handling), consistent with how min/max/mean/idw benefit from edge emphasis on elevation.Changes
process_dsm(dsm, grid_method)returns filled data only forstdevandcount; other methods keep the existing high-pass.serve_tilepassesgrid_methodinto processing.stdevandcountundertiles/anddsms/so those URL paths work like the other methods.