-
-
Notifications
You must be signed in to change notification settings - Fork 105
Show screenshots in search list #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danirabbit
wants to merge
17
commits into
main
Choose a base branch
from
danirabbit/searchlistitem-screenshots
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−10
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8d310c2
Show screenshots in search list
danirabbit 494994d
Grid view
danirabbit c4f3e46
merge main
danirabbit 8200813
Use screenshot widget
danirabbit 75aaec8
Merge main
danirabbit 32cd217
Merge branch 'main' into danirabbit/searchlistitem-screenshots
ryonakano 391d474
Revert using Grid
danirabbit 31d57cf
use screenshot height
danirabbit 2f96e12
Merge branch 'main' into danirabbit/searchlistitem-screenshots
danirabbit 47f3441
Merge branch 'main' into danirabbit/searchlistitem-screenshots
danirabbit 212dfbd
Merge branch 'main' into danirabbit/searchlistitem-screenshots
danirabbit 2c33f8f
Merge branch 'main' into danirabbit/searchlistitem-screenshots
zeebok f30cb56
Use ClampScrollable
danirabbit 36171db
Merge branch 'main' into danirabbit/searchlistitem-screenshots
jeremypw 4cafd04
Merge branch 'main' into danirabbit/searchlistitem-screenshots
zeebok d2b77e8
Merge branch 'main' into danirabbit/searchlistitem-screenshots
zeebok c86ff1e
Merge branch 'main' into danirabbit/searchlistitem-screenshots
jeremypw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,23 @@ | ||
| navigation-view-page.search { | ||
| gridview { | ||
| border-spacing: 1em 2em; | ||
|
|
||
| child { | ||
| border-radius: 1em; | ||
| padding-bottom: 0.5em; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| search-list-item { | ||
| border-spacing: 1em 0; | ||
| margin: 0.5em 1em; | ||
| search-list-item { | ||
| border-spacing: 1em 0; | ||
| margin: 0.5em 1em; | ||
|
|
||
| image { | ||
| margin: 0 -4px; | ||
| } | ||
| } | ||
|
|
||
| screenshot { | ||
| margin-top: calc(1em - 3px); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need null check for
screenshotand `screenshot.get_image() else appcenter crashes for some searches.