-
Notifications
You must be signed in to change notification settings - Fork 22
feat(Tooltip): add boundary prop to hide tooltip when it escapes an element #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+23
−1
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ import { | |
| arrow, | ||
| autoUpdate, | ||
| flip, | ||
| hide, | ||
| offset, | ||
| type OpenChangeReason, | ||
| type Placement, | ||
|
|
@@ -77,6 +78,17 @@ export interface CommonUseTooltipProps { | |
| */ | ||
| isTriggerInteractive: boolean; | ||
|
|
||
| /** | ||
| * An optional boundary element to constrain the tooltip within. | ||
| * When provided, the tooltip will be hidden if it escapes this boundary. | ||
| * Also passed to the `flip` middleware so it can choose a placement that | ||
| * keeps the tooltip inside the boundary. | ||
| * Accepts a single Element or an array of Elements. Useful for tooltips | ||
| * near containers they should not overlap (e.g. the message composer). | ||
| * @default undefined | ||
| */ | ||
| boundary?: Element | null | Element[]; | ||
|
|
||
| /** | ||
| * Additional aria-* attributes to pass through to the floating tooltip for | ||
| * edge cases which require more user awareness like errors & alerts. | ||
|
|
@@ -111,6 +123,7 @@ export function useTooltip({ | |
| caption, | ||
| "aria-atomic": ariaAtomic, | ||
| "aria-live": ariaLive, | ||
| boundary, | ||
| ...props | ||
| }: UseTooltipProps) { | ||
| const labelId = useId(); | ||
|
|
@@ -143,8 +156,19 @@ export function useTooltip({ | |
| crossAxis: placement.includes("-"), | ||
| fallbackAxisSideDirection: "start", | ||
| padding: 5, | ||
| // Only pass boundary if set — FloatingUI's Boundary type excludes null | ||
| ...(boundary ? { boundary } : {}), | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not use
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed both. |
||
| }), | ||
| shift({ padding: 5 }), | ||
| ...(boundary | ||
| ? [ | ||
| hide({ | ||
| strategy: "escaped", | ||
| boundary, | ||
| padding: 6, | ||
| }), | ||
| ] | ||
| : []), | ||
| // add the little arrow along with the floating content | ||
| arrow({ | ||
| element: arrowRef, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.