4/6 Add OtlpIngest runner with backpressure-aware retries#2137
Open
gareth-ellis wants to merge 4 commits into
Open
4/6 Add OtlpIngest runner with backpressure-aware retries#2137gareth-ellis wants to merge 4 commits into
gareth-ellis wants to merge 4 commits into
Conversation
The ApiError handler in execute_single() decodes `e.body`, `e.error`, and `e.info` as UTF-8 to build a human-readable error message. When the body is binary (e.g., binary protobuf returned by ES OTLP endpoints on 4xx/5xx), the strict decode raises UnicodeDecodeError, which crashes the worker mid-task. Switch the six decode() calls to use errors="replace" so undecodable bytes become U+FFFD instead of aborting the worker. No semantic change for valid UTF-8 (the common case). This is a latent bug independent of OTLP — any operation that surfaces a binary error body would have hit it.
Introduces OtlpProtobufFile in esrally/utils/io.py for reading/writing length-prefixed OTLP ExportMetricsServiceRequest protobufs, plus an offset sidecar to allow worker partitions to seek without scanning. Wires preparation into esrally/track/loader.py and esrally/track/track.py: - New OTLP document set fields (otlp_pb_size_in_bytes, etc.) - prepare_otlp_document_set tries to download a .pb from the corpus base URL, otherwise converts a local JSON corpus to .pb on disk. - set_absolute_data_path picks up the .pb when present. Adds OTLP protobuf bindings to pyproject.toml (opentelemetry-proto). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
OtlpParamSource streams length-prefixed protobuf records out of an OtlpProtobufFile, partitions them across workers using the offset sidecar, and surfaces percent_completed so the progress bar tracks real progress. Supports a "looped" mode that cycles the partition indefinitely for time-bound benchmarks. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
OtlpIngest POSTs serialized protobuf bytes to the OTLP metrics endpoint, disabling transport-level fast retries in favour of an explicit exponential-with-full-jitter backoff loop. 429/502/503/504 and connection errors are retried; non-retryable ApiErrors return a failure dict so the driver records the error without crashing the worker. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
This was referenced May 29, 2026
gareth-ellis
changed the title
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
OtlpIngestrunner inesrally/driver/runner.py— POSTs the serialized protobuf bytes to the OTLP metrics endpoint.Key design choices:
es.options(max_retries=0)). The default elasticsearch-py retry loop fires 4 attempts back-to-back with no sleep, which hammers an already-overloaded ES under 429/503.retries-on-error(default 5) andretry-wait-period(default 0.5s, capped at 30s).application/x-protobufserializer +AsyncElasticsearch.perform_requestbypass to avoid Rally's REST-compatAcceptheaders that OTLP endpoints reject.Depends on #2135 — merge after #2135. Part 4 of 6.
Series
Test plan
🤖 Generated with Claude Code