Fix LVGL widget copy/paste serialization#1011
Open
song7641 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes LVGL widget copy/paste from the Widgets Structure panel.
The legacy action migration in Widget.beforeLoadHook was reading jsObject.action directly. During copy serialization, jsObject can still expose the Widget.action getter through the prototype, which triggers LVGL event lookup before the cloned object is attached to a Project root. That causes Project settings lookup to fail and prevents clipboard data from being written.
This change only migrates the legacy action field when it is an own property of the serialized object.
Verified: