added cosine matching loss#2482
Open
ankitpatnala wants to merge 2 commits into
Open
Conversation
Contributor
Author
github-actions
Bot
added
eval
clessig
requested changes
Jun 12, 2026
clessig
left a comment
clessig
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the implementation. Can we generalise the PR slightly to have a LossLatent (I think it's a regularisation term since it does not involve targets but this is a minor point), with the cosine being a specific implementation (RMSE or other losses are possible as well). We will also need to best structure the part in the model but let's first to this restructuring.
@MatKbauer : (I don't think so since this uses that target_aux_calculator but double-checking)
@sophie-xhonneux : for me this is more a regularisation term since no target are involved. Any opinion on this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added cosine matching loss which is used for constraining cosine similarity between consecutive forecasting latents
Issue Number
Link the Issue number this change addresses:
Closes #2481