Skip to content

call BatchSample method instead of repeating content #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TillHae wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

call BatchSample method instead of repeating content #2348

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
483a136
call BatchSample method instead of repeating content
TillHae May 11, 2026
ab47c8b
Merge branch 'develop' into thauer/develop/issue_1791
TillHae May 13, 2026
9647e38
Merge branch 'develop' into thauer/develop/issue_1791
TillHae May 18, 2026
d79f737
improve object-oriented design of batch architecture
TillHae May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/weathergen/datasets/batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,13 +472,7 @@ def get_num_source_steps(self) -> int:
"""
Get number of input/source steps from smallest of all available streams
"""
# TODO: define explicitly
lens = [
len(stream.source_tokens_cells)
for _, stream in self.target_samples.samples[0].streams_data.items()
]

return min(lens)
return self.target_samples.get_num_steps()

def get_num_target_steps(self) -> int:
"""
Expand Down
Loading