Skip to content

Increase MAX_DRAWIMAGES limit#405

Closed
scoqx wants to merge 2 commits into
ec-:mainfrom
scoqx:main
Closed

Increase MAX_DRAWIMAGES limit#405
scoqx wants to merge 2 commits into
ec-:mainfrom
scoqx:main

Conversation

@scoqx

@scoqx scoqx commented May 29, 2026

Copy link
Copy Markdown
Contributor

New emoji assets have been added for OSP2/OSP2-BE mods, requiring a higher limit for images drawn on the client side.

@ensiform

Copy link
Copy Markdown
Contributor

Should use a texture atlas to avoid too many images, no?

@scoqx

scoqx commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

Should use a texture atlas to avoid too many images, no?

No, we also added animated emojis, using shader animMap

@scoqx

scoqx commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

But using an atlas is a good idea. However, we'd need to remake everything. The easy way is to increase the limit in the engine. If that causes a problem, I'll understand

@ensiform

Copy link
Copy Markdown
Contributor

It's probably fine but the more limits you increase the more you make the source port hardware creep on requirements that being able to still run on older rigs takes more ram etc

@scoqx

scoqx commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

It's probably fine but the more limits you increase the more you make the source port hardware creep on requirements that being able to still run on older rigs takes more ram etc

I see your point, but doesn't the hardware load depend directly on the actual number of loaded textures, not the limit itself? Right now, the client just crashes. If we raise the limit, vanilla users on older rigs won't see any difference because their asset count stays the same. It just opens up possibilities for heavy mods, leaving the resource management to the players' hardware

@ec-

ec- commented May 29, 2026

Copy link
Copy Markdown
Owner

the easy way is to increase the limit in the engine

As it always happens - noone will optimize their code after that because 'just works' on current engine.
Consider optimizing your code

@scoqx

scoqx commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

the easy way is to increase the limit in the engine

As it always happens - noone will optimize their code after that because 'just works' on current engine. Consider optimizing your code

I said "easy" because we did all the work with emojis and when test we had the error message... didn't notice there's limitation. But okey, thanks for repsonse

@scoqx scoqx closed this May 29, 2026
@ensiform

Copy link
Copy Markdown
Contributor

Should use a texture atlas to avoid too many images, no?

No, we also added animated emojis, using shader animMap

Are they all animated or just some

@scoqx

scoqx commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

Should use a texture atlas to avoid too many images, no?

No, we also added animated emojis, using shader animMap

Are they all animated or just some

just some. About 30 emojis
I'll make it right, with image-atlases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants