Update generators submodule#269
Merged
Merged
Conversation
thisac
commented
May 12, 2026
| from dwave.graphs.generators.zephyr.graphs import zephyr_graph | ||
|
|
||
|
|
||
| class zephyr_coordinates(object): |
Contributor
Author
There was a problem hiding this comment.
This is directly copied over from the former zephyr.py, now zephyr/graphs.py below.
|
Looks good and consistent with the changes needed for the upcoming |
thisac
force-pushed
the
upgrade/generators-refactor
branch
from
460da07 to
12b8b1b
Compare
thisac
force-pushed
the
upgrade/generators-refactor
branch
from
12b8b1b to
76e79e8
Compare
randomir
reviewed
Jun 9, 2026
thisac
force-pushed
the
upgrade/generators-refactor
branch
from
5096f1a to
0a76525
Compare
randomir
approved these changes
Jun 10, 2026
randomir
left a comment
randomir
left a comment
Member
There was a problem hiding this comment.
Looks good.
Just don't forget to fix the tests.
| coordinates: | ||
| If :code:`True`, node labels are 5-tuple Zephyr indices. | ||
| check_node_list: | ||
| If :code:`True`, the ``node_list`` elements are checked for compatibility with |
Member
There was a problem hiding this comment.
Not sure why :code: was mixed with the simple double-backtick here and elsewhere, but no harm in keeping it like that.
Contributor
Author
There was a problem hiding this comment.
Didn't change this AFAIK
Co-authored-by: Radomir Stevanovic <radomir.stevanovic@gmail.com>
thisac
force-pushed
the
upgrade/generators-refactor
branch
from
830e222 to
23049f1
Compare
Co-authored-by: Radomir Stevanovic <radomir.stevanovic@gmail.com>
Member
|
Oh, also forgot to mention, can you add the new coloring methods to the algorithms.rst docs? |
Co-authored-by: Radomir Stevanovic <radomir.stevanovic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update generators submodule in preparation for incoming topology utils.
See #266.
AI Generation Disclosure
GitHub Copilot was used to