Skip to content

fix(engine-formula): skip embedded refs for other formulas#6983

Open
OTime-Coder wants to merge 1 commit into
devfrom
fix/array-formula-other-formula-embedded-ref
Open

fix(engine-formula): skip embedded refs for other formulas#6983
OTime-Coder wants to merge 1 commit into
devfrom
fix/array-formula-other-formula-embedded-ref

Conversation

@OTime-Coder
Copy link
Copy Markdown
Contributor

@OTime-Coder OTime-Coder commented May 29, 2026

Summary

  • Track the current dependency tree formula type in formula runtime context.
  • Only collect embedded array formula refs for normal worksheet formulas.
  • Pass formula dependency type through calculation and dependency analysis paths.
  • Add a runtime regression test for OTHER_FORMULA vs NORMAL_FORMULA embedded ref collection.

Closes #6984

Validation

  • pnpm exec vitest run packages/engine-formula/src/services/tests/runtime.service.spec.ts
  • pnpm --filter @univerjs/engine-formula typecheck

@OTime-Coder OTime-Coder requested a review from wpxp123456 as a code owner May 29, 2026 11:07
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

@OTime-Coder OTime-Coder force-pushed the fix/array-formula-other-formula-embedded-ref branch from 266f10c to 96875a3 Compare May 29, 2026 11:11
@OTime-Coder OTime-Coder requested a review from DR-Univer May 29, 2026 11:12
@github-actions
Copy link
Copy Markdown

Playwright test results

passed  28 passed

Details

stats  28 tests across 12 suites
duration  7 minutes, 40 seconds
commit  96875a3
info  For more information, see full report and artifacts

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.37%. Comparing base (bdd4a43) to head (96875a3).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6983      +/-   ##
==========================================
+ Coverage   61.36%   61.37%   +0.01%     
==========================================
  Files        2587     2588       +1     
  Lines      150932   150936       +4     
  Branches    34269    34271       +2     
==========================================
+ Hits        92613    92634      +21     
+ Misses      58319    58302      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(engine-formula): other formula embedded array refs leak into worksheet snapshot

1 participant