Skip to content

feat(docs): replaced the hardcoded icons in the paragraph settings #6681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gsvart wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat(docs): replaced the hardcoded icons in the paragraph settings #6681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/docs-ui/src/views/paragraph-setting/Setting.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@

import { HorizontalAlign, LocaleService, SpacingRule } from '@univerjs/core';
import { borderClassName, clsx, InputNumber, Select, Tooltip } from '@univerjs/design';
import { AlignTextBothIcon, HorizontallyIcon, LeftJustifyingIcon, RightJustifyingIcon } from '@univerjs/icons';
import { useDependency } from '@univerjs/ui';
import { ComponentManager, useDependency } from '@univerjs/ui';
import { useMemo, useRef } from 'react';
import {
useCurrentParagraph,
Expand Down Expand Up @@ -64,6 +63,12 @@ const AutoFocusInputNumber = (props: {
};
export function ParagraphSetting() {
const localeService = useDependency(LocaleService);
const componentManager = useDependency(ComponentManager);

const LeftJustifyingIcon = componentManager.get('LeftJustifyingIcon');
const HorizontallyIcon = componentManager.get('HorizontallyIcon');
const RightJustifyingIcon = componentManager.get('RightJustifyingIcon');
const AlignTextBothIcon = componentManager.get('AlignTextBothIcon');

const alignmentOptions = useMemo(() => [
{ label: localeService.t('toolbar.alignLeft'), value: String(HorizontalAlign.LEFT), icon: <LeftJustifyingIcon /> },
Expand Down
Loading