Skip to content

fix(sheets): icons text and bg not update current color#6679

Closed
kenny-not-dead wants to merge 1 commit into
dream-num:devfrom
kenny-not-dead:sheetsIconFixes
Closed

fix(sheets): icons text and bg not update current color#6679
kenny-not-dead wants to merge 1 commit into
dream-num:devfrom
kenny-not-dead:sheetsIconFixes

Conversation

@kenny-not-dead
Copy link
Copy Markdown
Contributor

close #6676

Screencast.from.2026-03-13.16-35-53.mp4

After:

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@kenny-not-dead kenny-not-dead requested a review from jikkai as a code owner March 13, 2026 13:37
@univer-bot univer-bot Bot added the qa:untested This PR is ready to be tested label Mar 13, 2026
@jikkai
Copy link
Copy Markdown
Member

jikkai commented Jun 6, 2026

Thanks for the fix. I opened a new PR to replace this one.

The issue is not specific to sheet menu ids, so adding a menuItem.id.startsWith('sheet') guard in the generic ribbon hook is a bit too narrow. The new PR fixes the shared BUTTON_SELECTOR value flow instead, so the toolbar icon uses the latest emitted value while still preserving selection-derived state.

@jikkai jikkai closed this Jun 6, 2026
@kenny-not-dead kenny-not-dead deleted the sheetsIconFixes branch June 6, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa:untested This PR is ready to be tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] icon's text and background color do not change.

2 participants