Delete dead item group#11730
Open
Youssef1313 wants to merge 1 commit into
Open
Conversation
dotnet-policy-service
Bot
added
the
PR
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused MSBuild ItemGroup in the IntegrationTests multi-targeting props file that was conditioned on IsXUnitProject, a property that is not set anywhere in this repo and therefore never enabled. This simplifies the test build configuration and relies on Arcade’s standard unit test dependency handling.
Changes:
- Deleted a dead conditional
ItemGroupthat attempted to addxunit.v3based onIsXUnitProject. - Removed the accompanying explanatory comment block tied to that now-deleted condition.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mmanolova-msft
approved these changes
Jun 23, 2026
amarinov-msft
added
Included in test pass
Status:Proposed
Status:Completed
and removed
Queue for test pass
Status:Proposed
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsXUnitProjectisn't set anywhere in this repo. So the condition is always false today. Everything is handled correctly and automatically by Arcade.