[release/dnup] Fail loudly instead of masking a broken dotnetup with dotnet-install fallback#55209
Draft
nagilson wants to merge 1 commit into
Draft
[release/dnup] Fail loudly instead of masking a broken dotnetup with dotnet-install fallback#55209nagilson wants to merge 1 commit into
nagilson wants to merge 1 commit into
Conversation
…when dotnetup is broken On the release/dnup canary branch we want a broken dotnetup to surface as a hard CI failure rather than being silently masked by falling back to the standard dotnet-install script. Remove the dotnet-install fallbacks from the bootstrap SDK acquire path (configure-toolset.ps1) and the test-runtime install path (restore-toolset.ps1/.sh) so acquisition or install failures fail the build. The legitimate cross-architecture install-script path is preserved, since that is a dotnetup capability gap rather than a dotnetup failure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concern addressed
On the
release/dnupcanary branch, a badly-broken dotnetup should surface as a hard CI failure instead of being silently masked by falling back to the standard dotnet-install script. Today several fallbacks quietly hide dotnetup breakage, so we cannot tell from a green build whether dotnetup actually worked.Change
Remove the dotnet-install fallbacks that mask dotnetup failures, replacing them with a categorized
Write-PipelineTelemetryError+ExitWithExitCode:eng/configure-toolset.ps1- bootstrap SDK acquire path (previouslyWrite-Host ... return-> arcade silently fell back).eng/restore-toolset.ps1/eng/restore-toolset.sh- test-runtime acquire and install paths (previously fell back toInstallDotNetSharedFrameworksWithInstallScript).The bootstrap install failure path already hard-failed; this makes the acquire and runtime paths consistent.
Deliberately preserved
The cross-architecture install-script path (
if arch) is kept - that is a dotnetup capability gap (no--architectureoverride), not a dotnetup failure, so it must not hard-fail.Related
The companion fix for the misleading
exit codeoutput/false failures lives in main: #55208.Draft for CI validation.