Add location-gated AGENTS.md guidance for key src and test subtrees#55198
Open
mthalman wants to merge 6 commits into
Open
Add location-gated AGENTS.md guidance for key src and test subtrees#55198mthalman wants to merge 6 commits into
mthalman wants to merge 6 commits into
Conversation
Add nested, auto-loaded AGENTS.md files that give agents area-specific guidance only when editing the relevant subtree, keeping the root instructions lean. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
42 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds subtree-scoped AGENTS.md files to provide area-specific guidance for agents when working under key src/ and test/ directories, keeping root agent instructions shorter while still documenting important local conventions.
Changes:
- Introduces a
test/AGENTS.mdwith test-tree conventions (parallelism, skips, Verify snapshots, Helix partitioning). - Adds component-specific agent guidance under
src/for Tasks, Resolvers, Layout, CLI, Containers, dotnet-watch, and NetAnalyzers. - Documents a few area-specific invariants (e.g., diagnostic conventions in Tasks, resolver build gating, layout versioning flow).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/AGENTS.md | Adds test-area guidance (parallelism defaults, skips, Verify snapshots, Helix partitioning). |
| src/Tasks/AGENTS.md | Documents Tasks layout and diagnostics conventions (NETSDK messages, resx/xlf workflow). |
| src/Resolvers/AGENTS.md | Describes resolver projects and key constraints (linked sources, target frameworks, hostfxr interop, dependency pinning). |
| src/Microsoft.CodeAnalysis.NetAnalyzers/AGENTS.md | Adds guidance for analyzer development and release tracking conventions. |
| src/Layout/AGENTS.md | Documents layout’s role and versioning/bundling invariants. |
| src/Dotnet.Watch/AGENTS.md | Adds guidance for dotnet-watch structure, shared projitems, and test parallelism expectations. |
| src/Containers/AGENTS.md | Documents container feature structure, diagnostics code scheme, env var conventions, and test types. |
| src/Cli/AGENTS.md | Documents CLI project split, where code lives, and Verify snapshot test workflow. |
Drop the misleading claim that Microsoft.NET.TestFramework namespaces are exposed as global usings; those usings are xUnit-only and will be removed as the repo completes the MSTest transition. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Comment on lines
+7
to
+15
| Four projects, all multi-targeted (`net472` + current .NET) so tasks load in both | ||
| full-framework and .NET Core MSBuild: | ||
|
|
||
| | Project | Role | | ||
| |---------|------| | ||
| | `Microsoft.NET.Build.Tasks` | The core `Microsoft.NET.Sdk` task assembly **and** the targets that compose `dotnet build`. Ships in the SDK. | | ||
| | `Common` | Common shared source **linked into** both task assemblies — not its own package. | | ||
| | `Microsoft.NET.Build.Extensions.Tasks` | Tasks/targets for desktop/.NET Framework projects built **outside** the SDK. | | ||
| | `sdk-tasks` | Build-time-only tasks for **this repo's own** build/packaging — never shipped to users. | |
Frame the ''Where things live'' intro around the actionable rule: code added to Microsoft.NET.Build.Tasks or Microsoft.NET.Build.Extensions.Tasks must stay net472-compatible. Common is linked shared source that inherits the constraint, and sdk-tasks is current-.NET-only. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add nested, auto-loaded
AGENTS.mdfiles that give agents area-specific guidance only when editing the relevant subtree, keeping the root instructions lean.