Skip to content

superficial automated update, remove V1 AWS Java SDK#553

Open
denis-yuen wants to merge 4 commits into
developfrom
feature/remove_aws_sdk_1
Open

superficial automated update, remove V1 AWS Java SDK#553
denis-yuen wants to merge 4 commits into
developfrom
feature/remove_aws_sdk_1

Conversation

@denis-yuen

@denis-yuen denis-yuen commented Jun 24, 2026

Copy link
Copy Markdown
Member

Description
Tracking down isolated uses of Java V1 SDK.
Removing this usage though I'm a bit suspicious this is not the one AWS is detecting.
This is likely unused code, ran the automated migration with some maanual adjustments that the automation could not handle.

Review Instructions
Build passes, this is not likely being used (i.e. we only use this module to download tool files for ClamAV scanning if needed)

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-7615

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install in the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If you are changing dependencies, check with dependabot to ensure you are not introducing new high/critical vulnerabilities
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Jun 24, 2026
@denis-yuen denis-yuen changed the title superficial automated update superficial automated update, remove V1 AWS Java SDK Jun 24, 2026
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 44.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.85%. Comparing base (6c101de) to head (b091b94).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ockstore/toolbackup/client/cli/S3Communicator.java 44.00% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #553   +/-   ##
==========================================
  Coverage      15.84%   15.85%           
  Complexity       100      100           
==========================================
  Files             40       40           
  Lines           2335     2328    -7     
  Branches         185      186    +1     
==========================================
- Hits             370      369    -1     
+ Misses          1941     1934    -7     
- Partials          24       25    +1     
Flag Coverage Δ
metricsaggregator 10.52% <0.00%> (+0.03%) ⬆️
toolbackup 15.85% <44.00%> (+<0.01%) ⬆️
tooltester 10.52% <0.00%> (+0.03%) ⬆️
topicgenerator 10.52% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@denis-yuen denis-yuen requested review from a team, nolunwa-ucsc and svonworl and removed request for a team June 24, 2026 19:06
}

void uploadDirectory(String bucketName, String keyPrefix, String dirPath, List<File> files, boolean encrypt) {
void uploadDirectory(String bucketName, String keyPrefix, String dirPath, List<File> files, boolean encrypt) throws ExecutionException, InterruptedException {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it matter that the encrypt parameter no longer has any effect?

@denis-yuen denis-yuen Jul 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. The original idea was to back-up end-user Docker containers on S3, so while we could encrypt them so they were public data anyway.

Now, it makes even less sense since this (submodule) is primarily just to download stuff to ClamAV. Will remove

@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
51.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@denis-yuen denis-yuen requested a review from svonworl July 2, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants