superficial automated update, remove V1 AWS Java SDK#553
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #553 +/- ##
==========================================
Coverage 15.84% 15.85%
Complexity 100 100
==========================================
Files 40 40
Lines 2335 2328 -7
Branches 185 186 +1
==========================================
- Hits 370 369 -1
+ Misses 1941 1934 -7
- Partials 24 25 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| void uploadDirectory(String bucketName, String keyPrefix, String dirPath, List<File> files, boolean encrypt) { | ||
| void uploadDirectory(String bucketName, String keyPrefix, String dirPath, List<File> files, boolean encrypt) throws ExecutionException, InterruptedException { |
There was a problem hiding this comment.
Does it matter that the encrypt parameter no longer has any effect?
There was a problem hiding this comment.
I don't think so. The original idea was to back-up end-user Docker containers on S3, so while we could encrypt them so they were public data anyway.
Now, it makes even less sense since this (submodule) is primarily just to download stuff to ClamAV. Will remove
|


Description
Tracking down isolated uses of Java V1 SDK.
Removing this usage though I'm a bit suspicious this is not the one AWS is detecting.
This is likely unused code, ran the automated migration with some maanual adjustments that the automation could not handle.
Review Instructions
Build passes, this is not likely being used (i.e. we only use this module to download tool files for ClamAV scanning if needed)
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-7615
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean installin the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)