Declare marked and DOMPurify as ESLint globals - #46
Merged
Conversation
Both libraries are loaded from CDN script tags in index.html and used behind typeof guards in renderer.js, but ESLint's no-undef flagged them as undefined, failing lint runs. https://claude.ai/code/session_01Pdr2u5eE9XswikXHCjZNs5
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Testing summary
python/.venv(matching the existing gitignore entry) with the light deps (anthropic, python-dotenv, requests); GUI deps (pywebview, pystray, pynput) skipped since the app window/tray cannot run headless.py_compilepasses for all Python sources.Apidispatcher and services directly (withXDG_CONFIG_HOMEpointed at a scratch dir):settings.json;send-messagewithout an API key returns the expected configuration error;$HOMEand to protected paths (/etc/...) are refused; write/read roundtrip inside home works; missing-file read errors surface cleanly;~expansion works;sleep 5with 1s timeout fails gracefully);githubtester correctly reports a missing token; saving an empty secret preserves the existing value.node --checkpasses for all renderer JS.Fixes
eslint:recommended, as run by the repo's ESLint workflow) failed with twono-undeferrors inrenderer.jsformarkedandDOMPurify. Both are loaded from CDN script tags inindex.htmland already used behindtypeofguards, so they are now declared as readonly globals in.eslintrc.js. ESLint exits clean afterwards.https://claude.ai/code/session_01Pdr2u5eE9XswikXHCjZNs5
Generated by Claude Code