Skip to content

Configure TLS CipherSuites and CurvePreferences - #4922

Open
akhilnittala wants to merge 2 commits into
dexidp:masterfrom
akhilnittala:usr/akhil/ConfigureDexCiphersAndCurves
Open

Configure TLS CipherSuites and CurvePreferences#4922
akhilnittala wants to merge 2 commits into
dexidp:masterfrom
akhilnittala:usr/akhil/ConfigureDexCiphersAndCurves

Conversation

@akhilnittala

Copy link
Copy Markdown

Overview

TLS Ciphersuites are hardcoded currently, to meet the platform side compliance ciphersuites needs to be configureable, so made changes for tls ciphersuites and curve preferences to be configurable for web.

What this PR does / why we need it

Configures the tls ciphersuites and curvepreferences based on the parameters in config.yaml

Fixes: #4913

Signed-off-by: akhil nittala <nakhil@redhat.com>
Copilot AI review requested due to automatic review settings July 22, 2026 15:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the HTTPS listener’s TLS configuration more flexible by allowing operators to configure cipher suites (and curve preferences) from the web section of the config file, instead of relying on a fixed hardcoded list.

Changes:

  • Add web.allowedTLSCiphers to configure the tls.Config.CipherSuites used by the HTTPS endpoint.
  • Add parseCipherSuites helper plus unit tests for cipher-suite name parsing.
  • Add web.allowedCurvePreferences and wire it into tls.Config.CurvePreferences.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
cmd/dex/serve.go Reads new web TLS settings, builds tls.Config accordingly, and adds parseCipherSuites.
cmd/dex/serve_test.go Adds unit tests for parseCipherSuites.
cmd/dex/config.go Extends the Web config struct with new TLS configuration fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/dex/serve.go Outdated
Comment thread cmd/dex/config.go Outdated
Comment thread cmd/dex/serve.go
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala

Copy link
Copy Markdown
Author

@nabokihms @sagikazarmark could you please help me in review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allowedTLSCiphers flag can be made configurable to align for platform needs.

2 participants