Configure TLS CipherSuites and CurvePreferences - #4922
Open
akhilnittala wants to merge 2 commits into
Open
Conversation
Signed-off-by: akhil nittala <nakhil@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the HTTPS listener’s TLS configuration more flexible by allowing operators to configure cipher suites (and curve preferences) from the web section of the config file, instead of relying on a fixed hardcoded list.
Changes:
- Add
web.allowedTLSCiphersto configure thetls.Config.CipherSuitesused by the HTTPS endpoint. - Add
parseCipherSuiteshelper plus unit tests for cipher-suite name parsing. - Add
web.allowedCurvePreferencesand wire it intotls.Config.CurvePreferences.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cmd/dex/serve.go | Reads new web TLS settings, builds tls.Config accordingly, and adds parseCipherSuites. |
| cmd/dex/serve_test.go | Adds unit tests for parseCipherSuites. |
| cmd/dex/config.go | Extends the Web config struct with new TLS configuration fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: akhil nittala <nakhil@redhat.com>
Author
|
@nabokihms @sagikazarmark could you please help me in review process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
TLS Ciphersuites are hardcoded currently, to meet the platform side compliance ciphersuites needs to be configureable, so made changes for tls ciphersuites and curve preferences to be configurable for web.
What this PR does / why we need it
Configures the tls ciphersuites and curvepreferences based on the parameters in config.yaml
Fixes: #4913