feat: allow configuration of downloader connection socket & read timeouts#509
Merged
jeremylong merged 2 commits intoJul 1, 2026
Merged
Conversation
Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds configurable HTTP timeouts to the Gradle plugin extension and wires them into task settings, with corresponding spec updates and a version bump.
Changes:
- Introduce
connectionTimeoutandreadTimeout(asDuration) onDependencyCheckExtension. - Map the new duration values into
SettingsinConfiguredTask. - Update plugin specs to assert and configure the new timeout properties; bump
odcversion to a snapshot.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/test/groovy/org/owasp/dependencycheck/gradle/DependencyCheckGradlePluginSpec.groovy | Updates tests to configure/verify new timeout properties and refactors assertions into with { ... } blocks. |
| src/main/groovy/org/owasp/dependencycheck/gradle/tasks/ConfiguredTask.groovy | Maps new Duration timeout properties into settings keys as millisecond values. |
| src/main/groovy/org/owasp/dependencycheck/gradle/extension/DependencyCheckExtension.groovy | Adds Property<Duration> timeouts with setters (Duration + Number) and task input annotations. |
| gradle/libs.versions.toml | Bumps odc version to 12.2.3-SNAPSHOT. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeremylong
approved these changes
Jul 1, 2026
jeremylong
pushed a commit
that referenced
this pull request
Jul 1, 2026
…outs (#509) Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike all the other integrations the global Downloader timeouts aren't configurable via the Gradle plugin.
This allows using a
Durationor any number type to configure them.Needs dependency-check/DependencyCheck#8490 merged afterwards to synchronize the docs.