Add missing scp_component options to idrac_server_config_profile

[Klaas-]

depends on dell/omsdk#23 see #343 (comment)

SUMMARY

add missing scp_component options to idrac_server_config_profile
First step for #342

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

idrac_server_config_profile

ISSUES

References but does not fix #342

OUTPUT

no test cases changed, currently only testcases for idrac scp_component exist

ADDITIONAL INFORMATION

[Klaas-]

Forgot to add signoff as requested in dco, I would consider this a very minor update though :)

[Klaas-]

During my testing (scp_component eventfilters) I noticed that scp does not properly apply when using:
shutdown_type: NoReboot
it leads to the apply job being paused with 20% with message "SYS296: No reboot Server Configuration Profile Import job scheduled, Waiting for System Reboot to complete the operation."

When using:
shutdown_type: Graceful
the scp is job is being executed properly, the system is not rebooted. I am guessing this is not an ansible issue but how the idrac works. Should this be reported to Dell or is this viewed as a documentation only issue?

[anupamaloke]

LGTM

[Klaas-]

@anupamaloke who would I contact about the problem with shutdown_type: NoReboot from comment #343 (comment) ? Should that be handled in a support case?

[anupamaloke]

@anupamaloke who would I contact about the problem with shutdown_type: NoReboot from comment #343 (comment) ? Should that be handled in a support case?

@Klaas-, as per the iDRAC documentation, this is the correct behaviour. Following is what the iDRAC documentation says:

Shutdown : Select one of the following options:

• Graceful
• Forced
• No Reboot (Manually Reboot System)

NOTE: If No Reboot option is selected, no configuration changes will get applied for the SCP import job until the next manual server reboot.

In your playbook, since you set the shutdown_type to NoReboot, the import SCP job was waiting for the server reboot to happen before it could be applied. By default, it is Graceful so that iDRAC will gracefully reboot the server (without manual intervention) if a server reboot is at all needed for certain configuration.

[Klaas-]

hmm okay, I think I'll PR something for the docs of the ansible module then. But that also means there is no "do not reboot" option? and I need to check somehow if graceful will reboot the server or not

[ansible-collections-svc]

Can one of the admins verify this patch?

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.03%. Comparing base (2f88383) to head (88f715f).
⚠️ Report is 1087 commits behind head on collections.

Additional details and impacted files

@@               Coverage Diff               @@
##           collections     #343      +/-   ##
===============================================
+ Coverage        80.88%   81.03%   +0.14%     
===============================================
  Files              382      191     -191     
  Lines            60598    30299   -30299     
  Branches          9554     4777    -4777     
===============================================
- Hits             49014    24552   -24462     
+ Misses           10172     5069    -5103     
+ Partials          1412      678     -734     

Flag	Coverage Δ
units	81.00% <ø> (+0.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Klaas-]

Hi @sachin-apa
I don't think this is mergeable without the PR in dell/omsdk#23

[Klaas-]

At least that is what I wrote ~2 years ago in #343 (comment)

[sachin-apa]

Hi @sachin-apa I don't think this is mergeable without the PR in dell/omsdk#23

@Klaas- this module has evolved over 2 years !! it is now independent of omsdk, we have few more enhancement planned in this month, we will merge this PR and add those enhancements/fixes on top of it..

[Klaas-]

Hi @sachin-apa I don't think this is mergeable without the PR in dell/omsdk#23

@Klaas- this module has evolved over 2 years !! it is now independent of omsdk, we have few more enhancement planned in this month, we will merge this PR and add those enhancements/fixes on top of it..

That's good to hear, I haven't followed it closely I have to admit :) I guess I'll just strike the reference from the initial comment then