Use screen name instead of IP address to announce server through zeroconf#1286
Open
nicerloop wants to merge 2 commits into
Open
Use screen name instead of IP address to announce server through zeroconf#1286nicerloop wants to merge 2 commits into
nicerloop wants to merge 2 commits into
Conversation
Author
p12tic
approved these changes
Nov 1, 2021
Member
|
Code looks good to me. |
p12tic
requested changes
Nov 1, 2021
Member
p12tic
left a comment
p12tic
left a comment
There was a problem hiding this comment.
Please add a release note in the doc/newsfragments directory of the repository.
ghost
mentioned this pull request
|
It's especially stupid when "auto config" greys out "server IP" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same way it is done for client.
See symless/synergy@f2cc582 from myself.